Stale BAO_BROKER_SOCKET references in startup error and config doc comment #34
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
BAO_BROKER_SOCKETno longer exists — the broker process was removed infeat/direct-tpm(merged 2026-10-18), and the OpenBao connection is nowBAO_ADDR+ the TPM settings. Two places still name it, so an operator who hits either is told to set a variable ER ignores:src/main.rs:821— the[[managed_cert]]startup bail: "requires the OpenBao connection — set BAO_ADDR and BAO_BROKER_SOCKET"src/config.rs:332— comment: "The OpenBao connection is configured whenever BAO_ADDR + BAO_BROKER_SOCKET are …"Both should name whatever actually gates
config.openbaobeingSome(BAO_ADDR, plus the TPM cert/key paths). Text only — no behaviour change.Found while answering a question about startup dependencies; not fixed inline per the standing rule.
Fixed by the v2.0.0 removal. No
BAO_BROKER_SOCKETreference remains anywhere in the tree. The only survivingBAO_strings are inmain.rs's removed-variable list, which hard-errors onBAO_MASTER_KEY_PATHandBAO_MASTER_KEY_FIELDnaming their replacement — that is the intended behaviour, not a stale reference.