IsoHex/edge-router
Watch
1
0
Fork
You've already forked edge-router
 0
Code Issues 11 Pull requests Releases 2 Packages 1 Activity Actions

docker-compose.yml sets ALLOWED_ADMIN_HOSTS but no code reads it #12

New issue
Open
opened 2026-08-03 09:59:09 +00:00 by james.oates · 0 comments
james.oates commented 2026-08-03 09:59:09 +00:00
Owner
Copy link

While cleaning up the dead ALLOWED_ADMIN_IPS env var in docker-compose.yml (Task 14 of the network-access-control plan), I noticed ALLOWED_ADMIN_HOSTS in the same environment: block also has no consumer:

grep -rn "ALLOWED_ADMIN_HOSTS" src/
# (no matches)

routes_config.rs has a comment confirming this is intentional-ish: "Note: allowed_admin_hosts is intentionally absent — admin host is set via [admin] block" — so the admin host is configured through the TOML [admin] block instead, and this env var line in docker-compose.yml is stale, same class of issue as the ALLOWED_ADMIN_IPS line that was just removed.

Out of scope for Task 14 (which only covered ALLOWED_ADMIN_IPS from the allowed_ips → access_rules migration), so logging rather than fixing inline. Likely fix: remove the ALLOWED_ADMIN_HOSTS=... line from docker-compose.yml's environment: block, same as was just done for ALLOWED_ADMIN_IPS.

While cleaning up the dead `ALLOWED_ADMIN_IPS` env var in `docker-compose.yml` (Task 14 of the network-access-control plan), I noticed `ALLOWED_ADMIN_HOSTS` in the same `environment:` block also has no consumer: ``` grep -rn "ALLOWED_ADMIN_HOSTS" src/ # (no matches) ``` `routes_config.rs` has a comment confirming this is intentional-ish: "Note: allowed_admin_hosts is intentionally absent — admin host is set via [admin] block" — so the admin host is configured through the TOML `[admin]` block instead, and this env var line in `docker-compose.yml` is stale, same class of issue as the `ALLOWED_ADMIN_IPS` line that was just removed. Out of scope for Task 14 (which only covered `ALLOWED_ADMIN_IPS` from the `allowed_ips` → `access_rules` migration), so logging rather than fixing inline. Likely fix: remove the `ALLOWED_ADMIN_HOSTS=...` line from `docker-compose.yml`'s `environment:` block, same as was just done for `ALLOWED_ADMIN_IPS`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/openbao-transit-broker
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
IsoHex/edge-router#12
No description provided.